[Webkit-unassigned] [Bug 72099] [WK2] Keyboard menu key should show context menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72099

--- Comment #26 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #24)
> Comment on attachment 284771 [details]
> Proposed patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284771&action=review
> 
> Ah great, I noticed this was broken, it's nice to have a patch.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:827
> > +    if ((event->keyval == GDK_KEY_Menu) || (((event)->state & GDK_SHIFT_MASK) && GDK_KEY_F10))
> 
> Remove the extra parens around event here.
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:4567
> > +void WebPageProxy::handleContextMenuKeyEvent()
> 
> Carlos, owners, do you think we should use PLATFORM(GTK) guards here, since
> it's only used by GTK? It's not really platform specific, but only used by a
> single platform, so I'm not sure.

Cross-platform code that builds fine in all ports and doesn't cause other ports to do any extra work, like in this case, shouldn't have any ifdef in my opinion. 

> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2157
> > +    Frame& frame = m_page->focusController().focusedOrMainFrame();
> 
> You have to adjust the #ifdefs here to avoid the unused variable build
> failure on Mac. You should guard the entire implementation of the function
> with #if !PLATFORM(MAC).
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2160
> > +#if !PLATFORM(MAC)
> 
> But TBH I'm not sure if it's the right #if, we have iOS nowadays after all.
> Maybe !PLATFORM(COCOA)? Or maybe put the whole function in a PLATFORM(GTK)
> guard? Let's see what Carlos and Apple say to use here.

I don't understand why there's a platform ifdef there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160801/da8e2949/attachment-0001.html>