<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [WK2] Keyboard menu key should show context menu"
href="https://bugs.webkit.org/show_bug.cgi?id=72099#c26">Comment # 26</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [WK2] Keyboard menu key should show context menu"
href="https://bugs.webkit.org/show_bug.cgi?id=72099">bug 72099</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=72099#c24">comment #24</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=284771&action=diff" name="attach_284771" title="Proposed patch">attachment 284771</a> <a href="attachment.cgi?id=284771&action=edit" title="Proposed patch">[details]</a></span>
> Proposed patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=284771&action=review">https://bugs.webkit.org/attachment.cgi?id=284771&action=review</a>
>
> Ah great, I noticed this was broken, it's nice to have a patch.
>
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:827
> > + if ((event->keyval == GDK_KEY_Menu) || (((event)->state & GDK_SHIFT_MASK) && GDK_KEY_F10))
>
> Remove the extra parens around event here.
>
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:4567
> > +void WebPageProxy::handleContextMenuKeyEvent()
>
> Carlos, owners, do you think we should use PLATFORM(GTK) guards here, since
> it's only used by GTK? It's not really platform specific, but only used by a
> single platform, so I'm not sure.</span >
Cross-platform code that builds fine in all ports and doesn't cause other ports to do any extra work, like in this case, shouldn't have any ifdef in my opinion.
<span class="quote">> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2157
> > + Frame& frame = m_page->focusController().focusedOrMainFrame();
>
> You have to adjust the #ifdefs here to avoid the unused variable build
> failure on Mac. You should guard the entire implementation of the function
> with #if !PLATFORM(MAC).
>
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2160
> > +#if !PLATFORM(MAC)
>
> But TBH I'm not sure if it's the right #if, we have iOS nowadays after all.
> Maybe !PLATFORM(COCOA)? Or maybe put the whole function in a PLATFORM(GTK)
> guard? Let's see what Carlos and Apple say to use here.</span >
I don't understand why there's a platform ifdef there.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>