[Webkit-unassigned] [Bug 159827] run-webkit-tests should trigger a spindump when WebContent process is unresponsive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159827

--- Comment #46 from Jonathan Bedard <jbedard at apple.com> ---
To address Daniel's comment (which I read-over before the last patch): I think the platform separation makes the logging message more clear.  However, given that (this is a case which will almost never happen (as has been reviewed a number of times in this patch), I think he is right to eliminate the platform differentiation.

Lastly, one of the patch changes has changed something I said about snprintf in response to Darin earlier.  As per http://www.cplusplus.com/reference/cstdio/snprintf/,
    Parameter n: "Maximum number of bytes to be used in the buffer.
    The generated string has a length of at most n-1, leaving space for the additional
    terminating null character."
So given that we instantiate the buffer with all NULL's, we shouldn't need to worry about overrunning out buffer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160729/0c8172fe/attachment.html>