<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests should trigger a spindump when WebContent process is unresponsive"
href="https://bugs.webkit.org/show_bug.cgi?id=159827#c46">Comment # 46</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests should trigger a spindump when WebContent process is unresponsive"
href="https://bugs.webkit.org/show_bug.cgi?id=159827">bug 159827</a>
from <span class="vcard"><a class="email" href="mailto:jbedard@apple.com" title="Jonathan Bedard <jbedard@apple.com>"> <span class="fn">Jonathan Bedard</span></a>
</span></b>
<pre>To address Daniel's comment (which I read-over before the last patch): I think the platform separation makes the logging message more clear. However, given that (this is a case which will almost never happen (as has been reviewed a number of times in this patch), I think he is right to eliminate the platform differentiation.
Lastly, one of the patch changes has changed something I said about snprintf in response to Darin earlier. As per <a href="http://www.cplusplus.com/reference/cstdio/snprintf/">http://www.cplusplus.com/reference/cstdio/snprintf/</a>,
Parameter n: "Maximum number of bytes to be used in the buffer.
The generated string has a length of at most n-1, leaving space for the additional
terminating null character."
So given that we instantiate the buffer with all NULL's, we shouldn't need to worry about overrunning out buffer.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>