[Webkit-unassigned] [Bug 160229] [GTK] ASSERTION FAILED: !m_adoptionIsRequired when Inspector Server is connected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160229

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 284672
  --> https://bugs.webkit.org/attachment.cgi?id=284672
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284672&action=review

> Source/WebCore/ChangeLog:11
> +        An assertion fails because refcount of SocketStreamHandle is
> +        incremented before adoptRef, in the constructor of
> +        SocketStreamHandle.  The constructor of SocketStreamHandle needs
> +        to increment recount because it passes this pointer to libsoup.

This is an incorrect solution; relaxAdoptionRequirement should *not* be used here. The correct solution is to make the constructor private and make a public creation function which does the rest of the job of initializing the object, *after* the constructor has run and we have the object pointer inside a Ref already.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160727/2390bb69/attachment-0001.html>