<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] ASSERTION FAILED: !m_adoptionIsRequired when Inspector Server is connected"
href="https://bugs.webkit.org/show_bug.cgi?id=160229#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] ASSERTION FAILED: !m_adoptionIsRequired when Inspector Server is connected"
href="https://bugs.webkit.org/show_bug.cgi?id=160229">bug 160229</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284672&action=diff" name="attach_284672" title="Patch">attachment 284672</a> <a href="attachment.cgi?id=284672&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284672&action=review">https://bugs.webkit.org/attachment.cgi?id=284672&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:11
> + An assertion fails because refcount of SocketStreamHandle is
> + incremented before adoptRef, in the constructor of
> + SocketStreamHandle. The constructor of SocketStreamHandle needs
> + to increment recount because it passes this pointer to libsoup.</span >
This is an incorrect solution; relaxAdoptionRequirement should *not* be used here. The correct solution is to make the constructor private and make a public creation function which does the rest of the job of initializing the object, *after* the constructor has run and we have the object pointer inside a Ref already.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>