[Webkit-unassigned] [Bug 160198] Crash Log Clobbering on Unbound Crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160198

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284614|commit-queue+               |
              Flags|                            |

--- Comment #7 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 284614
  --> https://bugs.webkit.org/attachment.cgi?id=284614
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284614&action=review

Looks good to me.

> Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:93
> +        if len(fs.splitext(output_filename)[1]) - 1 > 5:
> +            return output_filename + modifier

Shouldn't we check the extension for test name, not the full path?

Could you please add a comment explaining why this is needed and why it's temporary? Something like:

# self._test_name can contain either a test name, or <...> (e.g. test-name.txt or com.apple.WebKit.WebContent.Development.123).
# FIXME: Refactor to avoid using this variable inconsistently.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160726/e61d1831/attachment.html>