<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash Log Clobbering on Unbound Crashes"
href="https://bugs.webkit.org/show_bug.cgi?id=160198">bug 160198</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #284614 Flags</td>
<td>commit-queue+
</td>
<td>
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash Log Clobbering on Unbound Crashes"
href="https://bugs.webkit.org/show_bug.cgi?id=160198#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash Log Clobbering on Unbound Crashes"
href="https://bugs.webkit.org/show_bug.cgi?id=160198">bug 160198</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284614&action=diff" name="attach_284614" title="Patch">attachment 284614</a> <a href="attachment.cgi?id=284614&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284614&action=review">https://bugs.webkit.org/attachment.cgi?id=284614&action=review</a>
Looks good to me.
<span class="quote">> Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:93
> + if len(fs.splitext(output_filename)[1]) - 1 > 5:
> + return output_filename + modifier</span >
Shouldn't we check the extension for test name, not the full path?
Could you please add a comment explaining why this is needed and why it's temporary? Something like:
# self._test_name can contain either a test name, or <...> (e.g. test-name.txt or com.apple.WebKit.WebContent.Development.123).
# FIXME: Refactor to avoid using this variable inconsistently.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>