[Webkit-unassigned] [Bug 159827] run-webkit-tests should trigger a spindump when WebContent process is unresponsive

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 26 16:26:21 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159827

--- Comment #30 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 284650
  --> https://bugs.webkit.org/attachment.cgi?id=284650
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284650&action=review

>> Tools/WebKitTestRunner/TestInvocation.cpp:195
>> +    snprintf(buffer, sizeof(buffer), "#PROCESS UNRESPONSIVE - %s (pid %ld)\n", TestController::webProcessName(), static_cast<long>(pid));
> 
> Can we use snprintf_s instead of snprintf? Otherwise we aren’t guaranteed it gets null terminated. Or does that not exist on all the platforms we support?

I'm actually not sure if it's supported.  What I will do instead is ensure it's null terminated manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160726/b1759876/attachment.html>


More information about the webkit-unassigned mailing list