[Webkit-unassigned] [Bug 159827] run-webkit-tests should trigger a spindump when WebContent process is unresponsive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159827

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284650|review?                     |review+
              Flags|                            |

--- Comment #29 from Darin Adler <darin at apple.com> ---
Comment on attachment 284650
  --> https://bugs.webkit.org/attachment.cgi?id=284650
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284650&action=review

> Tools/WebKitTestRunner/TestInvocation.cpp:195
> +    snprintf(buffer, sizeof(buffer), "#PROCESS UNRESPONSIVE - %s (pid %ld)\n", TestController::webProcessName(), static_cast<long>(pid));

Can we use snprintf_s instead of snprintf? Otherwise we aren’t guaranteed it gets null terminated. Or does that not exist on all the platforms we support?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160726/a7c23a3b/attachment.html>