[Webkit-unassigned] [Bug 128928] Improve GDB backtrace generation for GTK/EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128928

--- Comment #13 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 283647
  --> https://bugs.webkit.org/attachment.cgi?id=283647
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283647&action=review

>> Tools/Scripts/process-linux-coredump:26
>> +    full_path = os.path.join(destination_directory, 'core-pid_%d.dump'  % int(pid))
> 
> Why do you need to convert the pid to int? Why not just use %s instead? Or the script could receive the path already built no?

No strong reason for the conversion. The script cannot receive the full path already built because the script invocation is hardcoded in the core_pattern.

>> Tools/Scripts/webkitpy/port/linux_get_crash_log_unittest.py:49
>> +        core_pattern = "|%s %%p /path/to/coredumps" % process_coredump_script_path
> 
> Shouldn't you remove the previous core_pattern assignation?

oops

>> Tools/WebKitTestRunner/TestController.cpp:1487
>>      pid_t pid = WKContextGetNetworkProcessIdentifier(m_context.get());
> 
> Ah, mac already has an impl of this. In that case it should be moved to the cross-platform files, I think, instead of duplicating it in GTK specific files.

Ok I can try this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160722/d1b5696e/attachment.html>