<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Improve GDB backtrace generation for GTK/EFL"
href="https://bugs.webkit.org/show_bug.cgi?id=128928#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Improve GDB backtrace generation for GTK/EFL"
href="https://bugs.webkit.org/show_bug.cgi?id=128928">bug 128928</a>
from <span class="vcard"><a class="email" href="mailto:pnormand@igalia.com" title="Philippe Normand <pnormand@igalia.com>"> <span class="fn">Philippe Normand</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=283647&action=diff" name="attach_283647" title="patch">attachment 283647</a> <a href="attachment.cgi?id=283647&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=283647&action=review">https://bugs.webkit.org/attachment.cgi?id=283647&action=review</a>
<span class="quote">>> Tools/Scripts/process-linux-coredump:26
>> + full_path = os.path.join(destination_directory, 'core-pid_%d.dump' % int(pid))
>
> Why do you need to convert the pid to int? Why not just use %s instead? Or the script could receive the path already built no?</span >
No strong reason for the conversion. The script cannot receive the full path already built because the script invocation is hardcoded in the core_pattern.
<span class="quote">>> Tools/Scripts/webkitpy/port/linux_get_crash_log_unittest.py:49
>> + core_pattern = "|%s %%p /path/to/coredumps" % process_coredump_script_path
>
> Shouldn't you remove the previous core_pattern assignation?</span >
oops
<span class="quote">>> Tools/WebKitTestRunner/TestController.cpp:1487
>> pid_t pid = WKContextGetNetworkProcessIdentifier(m_context.get());
>
> Ah, mac already has an impl of this. In that case it should be moved to the cross-platform files, I think, instead of duplicating it in GTK specific files.</span >
Ok I can try this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>