[Webkit-unassigned] [Bug 160023] [GTK] Fix some video/canvas tests that should be passing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160023

--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 284217
  --> https://bugs.webkit.org/attachment.cgi?id=284217
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284217&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:104
> +    , m_videoCanvasPixelComparisonTolerance(6)
> +#else
> +    , m_videoCanvasPixelComparisonTolerance(2)
>  #endif

I think this should be initialized in platformInitialize() instead of using platform ifdefs. We need this ifdef here because of the timer only.

> LayoutTests/fast/canvas/canvas-createPattern-video-loading.html:64
> +        var tolerance;
> +        if (window.testRunner)
> +            tolerance = testRunner.videoCanvasPixelComparisonTolerance;
> +        else
> +            tolerance = 2;

Maybe this could be converted into a function and moved to a common .js file, so that we can do videoCanvasPixelComparisonTolerance() directly in the tests instead of duplicating this in all tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160721/6c9b9a4c/attachment.html>