<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix some video/canvas tests that should be passing"
href="https://bugs.webkit.org/show_bug.cgi?id=160023#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix some video/canvas tests that should be passing"
href="https://bugs.webkit.org/show_bug.cgi?id=160023">bug 160023</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=284217&action=diff" name="attach_284217" title="Patch">attachment 284217</a> <a href="attachment.cgi?id=284217&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284217&action=review">https://bugs.webkit.org/attachment.cgi?id=284217&action=review</a>
<span class="quote">> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:104
> + , m_videoCanvasPixelComparisonTolerance(6)
> +#else
> + , m_videoCanvasPixelComparisonTolerance(2)
> #endif</span >
I think this should be initialized in platformInitialize() instead of using platform ifdefs. We need this ifdef here because of the timer only.
<span class="quote">> LayoutTests/fast/canvas/canvas-createPattern-video-loading.html:64
> + var tolerance;
> + if (window.testRunner)
> + tolerance = testRunner.videoCanvasPixelComparisonTolerance;
> + else
> + tolerance = 2;</span >
Maybe this could be converted into a function and moved to a common .js file, so that we can do videoCanvasPixelComparisonTolerance() directly in the tests instead of duplicating this in all tests.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>