[Webkit-unassigned] [Bug 159465] [GTK][Threaded Compositor] Web view background colors don't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159465

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 283004 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283004&action=review
> 
> > Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:87
> > +        m_drawsBackground = drawsBackground;
> 
> This is fine as it is, but my style is to capture only protectedThis and use
> it explicitly in the lambda, instead of capturing both this and
> protectedThis. I'm not sure which style is more prevalent in WebKit code.

There's no consensus last time we discussed it, some people (like me) prefer to also capture this to make the lambda body easier to read without having to use protectedThis-> everywhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160721/0cc5b0c6/attachment.html>