[Webkit-unassigned] [Bug 159455] [GTK] Web view background colors don't work in accelerated compositing mode
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 20 17:25:04 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=159455
Michael Catanzaro <mcatanzaro at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #282882|review? |review+
Flags| |
--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 282882
--> https://bugs.webkit.org/attachment.cgi?id=282882
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=282882&action=review
The compatibility issue should be mentioned when you prepare release notes for 2.14.
> Source/WebKit2/ChangeLog:12
> + window has an RGBA visual, even when setting a fully opaque brakcground, because we still need the web process
background
> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3519
> + * #GtkWidget:app-paintable property set to %TRUE, for backgrounds colors to work.
Get rid of this comma.
> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:192
> + xDamageNotifier().add(m_window.get(), [this, damageNotify = WTFMove(damageNotify)] {
Is it normal WebKit style to put spaces around the assignment operator here? I think it's easier to read without spaces.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160721/a092deba/attachment.html>
More information about the webkit-unassigned
mailing list