<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Web view background colors don't work in accelerated compositing mode"
href="https://bugs.webkit.org/show_bug.cgi?id=159455">bug 159455</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #282882 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Web view background colors don't work in accelerated compositing mode"
href="https://bugs.webkit.org/show_bug.cgi?id=159455#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Web view background colors don't work in accelerated compositing mode"
href="https://bugs.webkit.org/show_bug.cgi?id=159455">bug 159455</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=282882&action=diff" name="attach_282882" title="Patch">attachment 282882</a> <a href="attachment.cgi?id=282882&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=282882&action=review">https://bugs.webkit.org/attachment.cgi?id=282882&action=review</a>
The compatibility issue should be mentioned when you prepare release notes for 2.14.
<span class="quote">> Source/WebKit2/ChangeLog:12
> + window has an RGBA visual, even when setting a fully opaque brakcground, because we still need the web process</span >
background
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3519
> + * #GtkWidget:app-paintable property set to %TRUE, for backgrounds colors to work.</span >
Get rid of this comma.
<span class="quote">> Source/WebKit2/UIProcess/gtk/RedirectedXCompositeWindow.cpp:192
> + xDamageNotifier().add(m_window.get(), [this, damageNotify = WTFMove(damageNotify)] {</span >
Is it normal WebKit style to put spaces around the assignment operator here? I think it's easier to read without spaces.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>