[Webkit-unassigned] [Bug 159562] Build fails with GSTREAMER_GL when both desktop GL and GLES2 are enabled in gst-plugins-bad

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159562

--- Comment #5 from Olivier Blin <olivier.blin at softathome.com> ---
(In reply to comment #4)
> Comment on attachment 284017 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284017&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        OpenGLShims.h redefines GL functions.
> 
> How is OpenGLShims.h pulled in?
> 
> Not sure I like the #include move to the Base.h header, we try to keep our
> headers free of #includes as much as possible.

I don't like it either, it would be easy to forget and break.

Here is the include flow:
  MediaPlayerPrivateGStreamerBase.cpp
  MediaPlayerPrivateGStreamerBase.h
  TextureMapperGL.h (for TextureMapperGL::Flags m_textureMapperRotationFlag)
  GraphicsContext3D.h
  ANGLEWebKitBridge.h
  OpenGLShims.h

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160720/2f323c03/attachment.html>