<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Build fails with GSTREAMER_GL when both desktop GL and GLES2 are enabled in gst-plugins-bad"
href="https://bugs.webkit.org/show_bug.cgi?id=159562#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Build fails with GSTREAMER_GL when both desktop GL and GLES2 are enabled in gst-plugins-bad"
href="https://bugs.webkit.org/show_bug.cgi?id=159562">bug 159562</a>
from <span class="vcard"><a class="email" href="mailto:olivier.blin@softathome.com" title="Olivier Blin <olivier.blin@softathome.com>"> <span class="fn">Olivier Blin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159562#c4">comment #4</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=284017&action=diff" name="attach_284017" title="Patch">attachment 284017</a> <a href="attachment.cgi?id=284017&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=284017&action=review">https://bugs.webkit.org/attachment.cgi?id=284017&action=review</a>
>
> > Source/WebCore/ChangeLog:11
> > + OpenGLShims.h redefines GL functions.
>
> How is OpenGLShims.h pulled in?
>
> Not sure I like the #include move to the Base.h header, we try to keep our
> headers free of #includes as much as possible.</span >
I don't like it either, it would be easy to forget and break.
Here is the include flow:
MediaPlayerPrivateGStreamerBase.cpp
MediaPlayerPrivateGStreamerBase.h
TextureMapperGL.h (for TextureMapperGL::Flags m_textureMapperRotationFlag)
GraphicsContext3D.h
ANGLEWebKitBridge.h
OpenGLShims.h</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>