[Webkit-unassigned] [Bug 159827] run-webkit-tests should trigger a spindump when WebContent process is unresponsive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159827

--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 283805
  --> https://bugs.webkit.org/attachment.cgi?id=283805
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283805&action=review

> Tools/Scripts/webkitpy/port/driver.py:452
> +
> +            spindump_process = subprocess.Popen(['sudo', '-A', 'spindump', str(child_process_pid), '10', '-file', self._port.results_directory() + '/' + parsed_filename + '.spindump.txt'], stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
> +            read_line = spindump_process.stdout.readline()
> +            while read_line:
> +                if read_line:
> +                    _log.debug(read_line)
> +                read_line = spindump_process.stdout.readline()

This assumes password-less sudo access or that sudo was invoked within the password prompt timeout period. Otherwise, we will hang waiting for a password. This is not the correct place for such port-specific code. It should be in the port-specific Port object. Use Port.sample_process() as an example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160719/71a799ed/attachment-0001.html>