<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests should trigger a spindump when WebContent process is unresponsive"
href="https://bugs.webkit.org/show_bug.cgi?id=159827#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests should trigger a spindump when WebContent process is unresponsive"
href="https://bugs.webkit.org/show_bug.cgi?id=159827">bug 159827</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=283805&action=diff" name="attach_283805" title="Patch">attachment 283805</a> <a href="attachment.cgi?id=283805&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=283805&action=review">https://bugs.webkit.org/attachment.cgi?id=283805&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/port/driver.py:452
> +
> + spindump_process = subprocess.Popen(['sudo', '-A', 'spindump', str(child_process_pid), '10', '-file', self._port.results_directory() + '/' + parsed_filename + '.spindump.txt'], stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
> + read_line = spindump_process.stdout.readline()
> + while read_line:
> + if read_line:
> + _log.debug(read_line)
> + read_line = spindump_process.stdout.readline()</span >
This assumes password-less sudo access or that sudo was invoked within the password prompt timeout period. Otherwise, we will hang waiting for a password. This is not the correct place for such port-specific code. It should be in the port-specific Port object. Use Port.sample_process() as an example.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>