[Webkit-unassigned] [Bug 152316] [GTK] WebKitGtk+ uses too many file descriptors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152316

--- Comment #37 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #36)
> Comment on attachment 282771 [details]
> Updated patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282771&action=review
> 
> Yay.

Thanks for the review.

> > Source/WTF/wtf/UniStdExtras.h:51
> > +inline bool setCloseOnExec(int fileDescriptor)
> 
> This is probably too long to be an inline function; you risk reduced
> performance from increased code size. I would add a .cpp file and move the
> implementation there.

Ok.

> > Source/WTF/wtf/UniStdExtras.h:63
> > +inline int dupCloseOnExec(int fileDescriptor)
> 
> Ditto regarding inline.
> 
> But also, this function looks like just a replacement for dup3. I think it'd
> be worthwhile to implement it using dup3 in the #ifdef __linux__ case, and
> use your current code here only as a fallback.

No, this is not equivalent to dup3, we want dup to chose the new fd for us.

> > Source/WTF/wtf/UniStdExtras.h:70
> > +
> 
> Extra blank line here?

Yes.

> > Source/WebKit2/ChangeLog:27
> > +        objects having a valid file descriptor. Use dupCloseOnExec() con duplicate the handle and set the close on exec flag.
> 
> "con" is not the right word here... did you mean "to"?

Indeed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160713/8b626b7b/attachment.html>