<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] WebKitGtk+ uses too many file descriptors"
href="https://bugs.webkit.org/show_bug.cgi?id=152316#c37">Comment # 37</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] WebKitGtk+ uses too many file descriptors"
href="https://bugs.webkit.org/show_bug.cgi?id=152316">bug 152316</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=152316#c36">comment #36</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=282771&action=diff" name="attach_282771" title="Updated patch">attachment 282771</a> <a href="attachment.cgi?id=282771&action=edit" title="Updated patch">[details]</a></span>
> Updated patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=282771&action=review">https://bugs.webkit.org/attachment.cgi?id=282771&action=review</a>
>
> Yay.</span >
Thanks for the review.
<span class="quote">> > Source/WTF/wtf/UniStdExtras.h:51
> > +inline bool setCloseOnExec(int fileDescriptor)
>
> This is probably too long to be an inline function; you risk reduced
> performance from increased code size. I would add a .cpp file and move the
> implementation there.</span >
Ok.
<span class="quote">> > Source/WTF/wtf/UniStdExtras.h:63
> > +inline int dupCloseOnExec(int fileDescriptor)
>
> Ditto regarding inline.
>
> But also, this function looks like just a replacement for dup3. I think it'd
> be worthwhile to implement it using dup3 in the #ifdef __linux__ case, and
> use your current code here only as a fallback.</span >
No, this is not equivalent to dup3, we want dup to chose the new fd for us.
<span class="quote">> > Source/WTF/wtf/UniStdExtras.h:70
> > +
>
> Extra blank line here?</span >
Yes.
<span class="quote">> > Source/WebKit2/ChangeLog:27
> > + objects having a valid file descriptor. Use dupCloseOnExec() con duplicate the handle and set the close on exec flag.
>
> "con" is not the right word here... did you mean "to"?</span >
Indeed.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>