[Webkit-unassigned] [Bug 159666] Change CSSParser::sourceSize returning Optional<CSSParser::SourceSize>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159666

--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 283409
  --> https://bugs.webkit.org/attachment.cgi?id=283409
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283409&action=review

> Source/WebCore/css/CSSParser.cpp:1560
>      if (!value) {
>          value = parserValue.createCSSValue();
>          if (!value)
> -            value = CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_UNKNOWN);
> +            return Nullopt;
>      }
>      destroy(parserValue);

Oops, missed the storage leak here. We have to structure this so destroy(parserValue) is called even if we are going to return Nullopt.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160712/e19a81f4/attachment.html>