<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Change CSSParser::sourceSize returning Optional<CSSParser::SourceSize>"
href="https://bugs.webkit.org/show_bug.cgi?id=159666#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Change CSSParser::sourceSize returning Optional<CSSParser::SourceSize>"
href="https://bugs.webkit.org/show_bug.cgi?id=159666">bug 159666</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=283409&action=diff" name="attach_283409" title="Patch">attachment 283409</a> <a href="attachment.cgi?id=283409&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=283409&action=review">https://bugs.webkit.org/attachment.cgi?id=283409&action=review</a>
<span class="quote">> Source/WebCore/css/CSSParser.cpp:1560
> if (!value) {
> value = parserValue.createCSSValue();
> if (!value)
> - value = CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_UNKNOWN);
> + return Nullopt;
> }
> destroy(parserValue);</span >
Oops, missed the storage leak here. We have to structure this so destroy(parserValue) is called even if we are going to return Nullopt.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>