[Webkit-unassigned] [Bug 159666] Change CSSParser::sourceSize returning Optional<CSSParser::SourceSize>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 12 08:42:26 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159666

--- Comment #6 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to comment #5)
> Created attachment 283409 [details]
> Patch

(In reply to comment #4)
> Comment on attachment 283399 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283399&action=review
> 
> > Source/WebCore/css/CSSGrammar.y.in:580
> > +        auto result = parser->sourceSize(WTFMove(*$1), $2);
> > +        if (result)
> 
> I’d like this slightly better with the expression inside the if, but
> otherwise the patch looks perfect to me.

Done. Thanks for reviewing! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160712/d14247f9/attachment.html>


More information about the webkit-unassigned mailing list