<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Change CSSParser::sourceSize returning Optional<CSSParser::SourceSize>"
href="https://bugs.webkit.org/show_bug.cgi?id=159666#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Change CSSParser::sourceSize returning Optional<CSSParser::SourceSize>"
href="https://bugs.webkit.org/show_bug.cgi?id=159666">bug 159666</a>
from <span class="vcard"><a class="email" href="mailto:yoav@yoav.ws" title="Yoav Weiss <yoav@yoav.ws>"> <span class="fn">Yoav Weiss</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159666#c5">comment #5</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=283409&action=diff" name="attach_283409" title="Patch">attachment 283409</a> <a href="attachment.cgi?id=283409&action=edit" title="Patch">[details]</a></span>
> Patch</span >
(In reply to <a href="show_bug.cgi?id=159666#c4">comment #4</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=283399&action=diff" name="attach_283399" title="Patch">attachment 283399</a> <a href="attachment.cgi?id=283399&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=283399&action=review">https://bugs.webkit.org/attachment.cgi?id=283399&action=review</a>
>
> > Source/WebCore/css/CSSGrammar.y.in:580
> > + auto result = parser->sourceSize(WTFMove(*$1), $2);
> > + if (result)
>
> I’d like this slightly better with the expression inside the if, but
> otherwise the patch looks perfect to me.</span >
Done. Thanks for reviewing! :)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>