[Webkit-unassigned] [Bug 159552] [GStreamer][GL] crash within triggerRepaint

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159552

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #283139|review?                     |review+
              Flags|                            |

--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 283139
  --> https://bugs.webkit.org/attachment.cgi?id=283139
patch

> I understand the concerns about reducing performance but if there isn't we
> should create a function to do something like:
> 
> {
>      auto weakThis = player.createWeakPtr();
>      RunLoop::main().runNowIfMainThreadOrdispatch([weakThis]) { 
>          if (weakThis)
>              weakThis->m_player->sizeChanged();
>      });
> }
> 
> Otherwise I think we are creating these code structures and IMHO it makes
> code hard to read.

Let's not block landing this because of this nit, but please, open a new bug about this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160711/ceeaa58c/attachment-0001.html>