[Webkit-unassigned] [Bug 159385] ECMAScript 2016: %TypedArray%.prototype.includes implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159385

--- Comment #57 from Caio Lima <ticaiolima at gmail.com> ---
(In reply to comment #56)
> (In reply to comment #55)
> > (In reply to comment #54)
> > > https://build.webkit.org/builders/
> > > Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/3404/
> > > https://build.webkit.org/builders/
> > > Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/7277
> > > 
> > > It seems that this patch causes JSC test failures. Could you take a look?
> > 
> > Hey Yusuke, is it possible get the output of this LayoutTests run?
> 
> The results of the layout-tests can be seen in
> https://build.webkit.org/results/ :)

Well, the problem is weird. When I run "run-javascriptcore-tests", the output is different from "run-webkit-tests". Here is the diff:

--- /Users/caiolima/open_projects/WebKit/WebKitBuild/Debug/layout-test-results/js/typed-array-includes-expected.txt
+++ /Users/caiolima/open_projects/WebKit/WebKitBuild/Debug/layout-test-results/js/typed-array-includes-actual.txt
@@ -1,3 +1,8 @@
+JSRegress/typed-array-includes
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
 PASS tArray.includes(2) is true
 PASS !tArray.includes(4) is true
 PASS !tArray.includes(3, 3) is true
@@ -251,6 +256,7 @@
 PASS funcCallCount.callCount === 4 is true
 PASS funcCallCount.callCount === 5 is true
 PASS funcCallCount.callCount === 6 is true
+PASS no exception thrown
 PASS successfullyParsed is true

 TEST COMPLETE

I can move the test from LayoutTests to Source/JavaScriptCore/tests and avoid it breaks the "LayoutTests". However, I would like to know why this difference happens. Do you have any tips?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160711/cd2d0dbc/attachment.html>