<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - ECMAScript 2016: %TypedArray%.prototype.includes implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=159385#c57">Comment # 57</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - ECMAScript 2016: %TypedArray%.prototype.includes implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=159385">bug 159385</a>
from <span class="vcard"><a class="email" href="mailto:ticaiolima@gmail.com" title="Caio Lima <ticaiolima@gmail.com>"> <span class="fn">Caio Lima</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159385#c56">comment #56</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=159385#c55">comment #55</a>)
> > (In reply to <a href="show_bug.cgi?id=159385#c54">comment #54</a>)
> > > <a href="https://build.webkit.org/builders/">https://build.webkit.org/builders/</a>
> > > Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/3404/
> > > <a href="https://build.webkit.org/builders/">https://build.webkit.org/builders/</a>
> > > Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/7277
> > >
> > > It seems that this patch causes JSC test failures. Could you take a look?
> >
> > Hey Yusuke, is it possible get the output of this LayoutTests run?
>
> The results of the layout-tests can be seen in
> <a href="https://build.webkit.org/results/">https://build.webkit.org/results/</a> :)</span >
Well, the problem is weird. When I run "run-javascriptcore-tests", the output is different from "run-webkit-tests". Here is the diff:
--- /Users/caiolima/open_projects/WebKit/WebKitBuild/Debug/layout-test-results/js/typed-array-includes-expected.txt
+++ /Users/caiolima/open_projects/WebKit/WebKitBuild/Debug/layout-test-results/js/typed-array-includes-actual.txt
@@ -1,3 +1,8 @@
+JSRegress/typed-array-includes
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
PASS tArray.includes(2) is true
PASS !tArray.includes(4) is true
PASS !tArray.includes(3, 3) is true
@@ -251,6 +256,7 @@
PASS funcCallCount.callCount === 4 is true
PASS funcCallCount.callCount === 5 is true
PASS funcCallCount.callCount === 6 is true
+PASS no exception thrown
PASS successfullyParsed is true
TEST COMPLETE
I can move the test from LayoutTests to Source/JavaScriptCore/tests and avoid it breaks the "LayoutTests". However, I would like to know why this difference happens. Do you have any tips?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>