[Webkit-unassigned] [Bug 159410] When WKWebView prepares the session state blob, we should be able to filter it.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 6 14:35:51 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159410

--- Comment #12 from Yongjun Zhang <yongjun_zhang at apple.com> ---
(In reply to comment #11)
> Comment on attachment 282914 [details]
> Add a SPI to WKWebView so that we can filter the session state.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=282914&action=review
> 
> >> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3378
> >> +    WebKit::SessionState sessionState = _page->sessionState([handler](WebKit::WebBackForwardListItem& item) {
> > 
> > Can put the filter copy inside the lambda:
> > [handler = adoptNS([filter copy])]
> 
> I don't think the block needs to be copied at all? If it does, just use
> WTF::BlockPtr instead.

Right, we don't need copy here since WebPageProxy::sessionState is a synchronous call.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160706/3d2b3ab7/attachment.html>


More information about the webkit-unassigned mailing list