<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - When WKWebView prepares the session state blob, we should be able to filter it."
href="https://bugs.webkit.org/show_bug.cgi?id=159410#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - When WKWebView prepares the session state blob, we should be able to filter it."
href="https://bugs.webkit.org/show_bug.cgi?id=159410">bug 159410</a>
from <span class="vcard"><a class="email" href="mailto:yongjun_zhang@apple.com" title="Yongjun Zhang <yongjun_zhang@apple.com>"> <span class="fn">Yongjun Zhang</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=159410#c11">comment #11</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=282914&action=diff" name="attach_282914" title="Add a SPI to WKWebView so that we can filter the session state.">attachment 282914</a> <a href="attachment.cgi?id=282914&action=edit" title="Add a SPI to WKWebView so that we can filter the session state.">[details]</a></span>
> Add a SPI to WKWebView so that we can filter the session state.
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=282914&action=review">https://bugs.webkit.org/attachment.cgi?id=282914&action=review</a>
>
> >> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3378
> >> + WebKit::SessionState sessionState = _page->sessionState([handler](WebKit::WebBackForwardListItem& item) {
> >
> > Can put the filter copy inside the lambda:
> > [handler = adoptNS([filter copy])]
>
> I don't think the block needs to be copied at all? If it does, just use
> WTF::BlockPtr instead.</span >
Right, we don't need copy here since WebPageProxy::sessionState is a synchronous call.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>