[Webkit-unassigned] [Bug 159385] ECMAScript 2016: %TypedArray%.prototype.includes implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159385

--- Comment #20 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 282752
  --> https://bugs.webkit.org/attachment.cgi?id=282752
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282752&action=review

>> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h:211
>> +    TypedArrayType arrayType = exec->thisValue().getObject()->classInfo()->typedArrayStorageType;
> 
> This is less efficient than it should.
> 
> You are getting the array type at runtime.
> This condition can be fully determined at compile time from the template argument ViewClass.

Yeah the TypedArrayType can be found with ViewClass::TypedArrayStorageType

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160705/f4f11b52/attachment.html>