<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - ECMAScript 2016: %TypedArray%.prototype.includes implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=159385#c20">Comment # 20</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - ECMAScript 2016: %TypedArray%.prototype.includes implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=159385">bug 159385</a>
from <span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=282752&action=diff" name="attach_282752" title="Patch">attachment 282752</a> <a href="attachment.cgi?id=282752&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=282752&action=review">https://bugs.webkit.org/attachment.cgi?id=282752&action=review</a>
<span class="quote">>> Source/JavaScriptCore/runtime/JSGenericTypedArrayViewPrototypeFunctions.h:211
>> + TypedArrayType arrayType = exec->thisValue().getObject()->classInfo()->typedArrayStorageType;
>
> This is less efficient than it should.
>
> You are getting the array type at runtime.
> This condition can be fully determined at compile time from the template argument ViewClass.</span >
Yeah the TypedArrayType can be found with ViewClass::TypedArrayStorageType</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>