[Webkit-unassigned] [Bug 159212] [Coordinated Graphics] Modernize and cleanup CompositingCoordinator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159212

--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 282417
  --> https://bugs.webkit.org/attachment.cgi?id=282417
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282417&action=review

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:217
> +void CompositingCoordinator::updateImageBacking(CoordinatedImageBackingID imageID, RefPtr<CoordinatedSurface>& coordinatedSurface)

I don't think this should be receiving a reference to RefPtr.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:286
> +void CompositingCoordinator::createUpdateAtlas(uint32_t atlasID, RefPtr<CoordinatedSurface>& coordinatedSurface)

I don't think this should be receiving a reference to RefPtr.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:357
> +    if (auto layer = m_registeredLayers.get(layerID))

auto*, since m_registeredLayers is mapping IDs to pointers to CoordinatedGraphicsLayer objects.

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:88
> -    std::unique_ptr<CompositingCoordinator> m_coordinator;
> +    CompositingCoordinator m_coordinator;

You can drop WTF_MAKE_FAST_ALLOCATED from CompositingCoordinator class now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160704/85747e59/attachment.html>