<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Modernize and cleanup CompositingCoordinator"
href="https://bugs.webkit.org/show_bug.cgi?id=159212#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Coordinated Graphics] Modernize and cleanup CompositingCoordinator"
href="https://bugs.webkit.org/show_bug.cgi?id=159212">bug 159212</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=282417&action=diff" name="attach_282417" title="Rebased patch">attachment 282417</a> <a href="attachment.cgi?id=282417&action=edit" title="Rebased patch">[details]</a></span>
Rebased patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=282417&action=review">https://bugs.webkit.org/attachment.cgi?id=282417&action=review</a>
<span class="quote">> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:217
> +void CompositingCoordinator::updateImageBacking(CoordinatedImageBackingID imageID, RefPtr<CoordinatedSurface>& coordinatedSurface)</span >
I don't think this should be receiving a reference to RefPtr.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:286
> +void CompositingCoordinator::createUpdateAtlas(uint32_t atlasID, RefPtr<CoordinatedSurface>& coordinatedSurface)</span >
I don't think this should be receiving a reference to RefPtr.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:357
> + if (auto layer = m_registeredLayers.get(layerID))</span >
auto*, since m_registeredLayers is mapping IDs to pointers to CoordinatedGraphicsLayer objects.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:88
> - std::unique_ptr<CompositingCoordinator> m_coordinator;
> + CompositingCoordinator m_coordinator;</span >
You can drop WTF_MAKE_FAST_ALLOCATED from CompositingCoordinator class now.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>