[Webkit-unassigned] [Bug 152029] inspector/debugger/command-line-api-exception.html flakily times out on mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152029

--- Comment #7 from Brian Burg <bburg at apple.com> ---
Comment on attachment 282509
  --> https://bugs.webkit.org/attachment.cgi?id=282509
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=282509&action=review

> LayoutTests/inspector/debugger/command-line-api-exception-nested-catch.html:47
> +                if (!WebInspector.debuggerManager.activeCallFrame)

You *probably* could rewrite this using DebuggerManager's promises and avoid the phase thing. See comment below.

> LayoutTests/inspector/debugger/command-line-api-exception.html:36
> +                        WebInspector.debuggerManager.resume();

(applies throughout) Since many DebuggerManager commands return promises, you could do:

WebInspector.debuggerManager.resume().then(resolve, reject);

Internally, it does a single fire listener for the same event. This helps to keep the logic of event ordering inside DebuggerManager for many use cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160701/6cf88b8c/attachment.html>