<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - inspector/debugger/command-line-api-exception.html flakily times out on mac"
href="https://bugs.webkit.org/show_bug.cgi?id=152029#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - inspector/debugger/command-line-api-exception.html flakily times out on mac"
href="https://bugs.webkit.org/show_bug.cgi?id=152029">bug 152029</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=282509&action=diff" name="attach_282509" title="[PATCH] Proposed Fix">attachment 282509</a> <a href="attachment.cgi?id=282509&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=282509&action=review">https://bugs.webkit.org/attachment.cgi?id=282509&action=review</a>
<span class="quote">> LayoutTests/inspector/debugger/command-line-api-exception-nested-catch.html:47
> + if (!WebInspector.debuggerManager.activeCallFrame)</span >
You *probably* could rewrite this using DebuggerManager's promises and avoid the phase thing. See comment below.
<span class="quote">> LayoutTests/inspector/debugger/command-line-api-exception.html:36
> + WebInspector.debuggerManager.resume();</span >
(applies throughout) Since many DebuggerManager commands return promises, you could do:
WebInspector.debuggerManager.resume().then(resolve, reject);
Internally, it does a single fire listener for the same event. This helps to keep the logic of event ordering inside DebuggerManager for many use cases.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>