[Webkit-unassigned] [Bug 153712] generate-inspector-gresource-manifest.py uses the wrong python interpreter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 30 11:15:03 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=153712

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270312|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 270312
  --> https://bugs.webkit.org/attachment.cgi?id=270312
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270312&action=review

> Source/WebKit2/PlatformGTK.cmake:648
> +    COMMAND ${PYTHON_EXECUTABLE} ${TOOLS_DIR}/gtk/generate-inspector-gresource-manifest.py --output=${DERIVED_SOURCES_WEBKIT2GTK_DIR}/InspectorGResourceBundle.xml ${InspectorFiles} ${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol/InspectorBackendCommands.js

Ugh, I do not like working around the shebang in the file itself. I normally prefer to substitute the right python executable into the shebang with a configure replacement, but then the script would go in the build directory rather than Tools/gtk, and that's definitely undesired. r=me only because I'm pretty sure there's no better solution.

Normally, files that end in .py are understood to not be executable, and should not have shebangs. The python files under Tools/gtk don't seem to follow this rule.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160130/d5c2463f/attachment-0001.html>


More information about the webkit-unassigned mailing list