<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - generate-inspector-gresource-manifest.py uses the wrong python interpreter"
href="https://bugs.webkit.org/show_bug.cgi?id=153712">bug 153712</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #270312 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - generate-inspector-gresource-manifest.py uses the wrong python interpreter"
href="https://bugs.webkit.org/show_bug.cgi?id=153712#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - generate-inspector-gresource-manifest.py uses the wrong python interpreter"
href="https://bugs.webkit.org/show_bug.cgi?id=153712">bug 153712</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=270312&action=diff" name="attach_270312" title="patch">attachment 270312</a> <a href="attachment.cgi?id=270312&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=270312&action=review">https://bugs.webkit.org/attachment.cgi?id=270312&action=review</a>
<span class="quote">> Source/WebKit2/PlatformGTK.cmake:648
> + COMMAND ${PYTHON_EXECUTABLE} ${TOOLS_DIR}/gtk/generate-inspector-gresource-manifest.py --output=${DERIVED_SOURCES_WEBKIT2GTK_DIR}/InspectorGResourceBundle.xml ${InspectorFiles} ${DERIVED_SOURCES_WEBINSPECTORUI_DIR}/UserInterface/Protocol/InspectorBackendCommands.js</span >
Ugh, I do not like working around the shebang in the file itself. I normally prefer to substitute the right python executable into the shebang with a configure replacement, but then the script would go in the build directory rather than Tools/gtk, and that's definitely undesired. r=me only because I'm pretty sure there's no better solution.
Normally, files that end in .py are understood to not be executable, and should not have shebangs. The python files under Tools/gtk don't seem to follow this rule.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>