[Webkit-unassigned] [Bug 153612] Cleanup: Make DedicatedWorkerThread::create() an inline template method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153612

--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
(In reply to comment #4)
> It seems somewhat strange to have a one-off variadic template here, since
> the number of parameters will never actually vary in practice.
> 

I know this is a one-off. I proposed this change because I've modified DedicatedWorkerThread::create() once in the patch for bug #153157 and plan to modify it again in a subsequent patch. Maybe we can come up with a better design for passing state to Web Worker threads. Currently, whenever we want to pass state to a Web Worker thread that cannot be derived from the existing state we passed then we need to modify DedicatedWorkerThread::create() among many other functions.

> I wonder if we should consider creating something similar to
> std::make_unique for Ref and RefPtr? That would let us remove this type of
> duplication all over our codebase.

Yes, we should do this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160128/425544bc/attachment-0001.html>