<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Cleanup: Make DedicatedWorkerThread::create() an inline template method"
href="https://bugs.webkit.org/show_bug.cgi?id=153612#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Cleanup: Make DedicatedWorkerThread::create() an inline template method"
href="https://bugs.webkit.org/show_bug.cgi?id=153612">bug 153612</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153612#c4">comment #4</a>)
<span class="quote">> It seems somewhat strange to have a one-off variadic template here, since
> the number of parameters will never actually vary in practice.
> </span >
I know this is a one-off. I proposed this change because I've modified DedicatedWorkerThread::create() once in the patch for <a class="bz_bug_link
bz_status_NEW "
title="NEW - CSP: Use the served CSP header for dedicated workers"
href="show_bug.cgi?id=153157">bug #153157</a> and plan to modify it again in a subsequent patch. Maybe we can come up with a better design for passing state to Web Worker threads. Currently, whenever we want to pass state to a Web Worker thread that cannot be derived from the existing state we passed then we need to modify DedicatedWorkerThread::create() among many other functions.
<span class="quote">> I wonder if we should consider creating something similar to
> std::make_unique for Ref and RefPtr? That would let us remove this type of
> duplication all over our codebase.</span >
Yes, we should do this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>