[Webkit-unassigned] [Bug 153516] Web Inspector: High Level Memory Overview Instrument
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 28 13:55:31 PST 2016
https://bugs.webkit.org/show_bug.cgi?id=153516
Brian Burg <bburg at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #269943|review? |review-
Flags| |
--- Comment #8 from Brian Burg <bburg at apple.com> ---
Comment on attachment 269943
--> https://bugs.webkit.org/attachment.cgi?id=269943
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=269943&action=review
Not too much work left before this is ready to go. Please post a patch that applies cleanly so I can try it out! :) Also, please split the variable-height overview graph thing.
> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js:113
> + function ysForRecord(record) {
Weird name. Maybe 'scaledPointSetForRecord'. Although I would really prefer that the chart itself be passed a scale and take responsibility for applying it as necessary. I can't think of any reason why the scale would vary by category, so just two scales is enough.
> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:45
> +
These variable names are funny =) but you should put in what the chart contains.
> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:46
> + let chart1Element = overviewElement.appendChild(document.createElement("div"));
UI nit: it's not clear from the static screenshot where the left chart gets its data. Is it from one single instant? If so, add a subtitle.
> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:50
> + chart1SubtitleElement.textContent = WebInspector.UIString("Breakdown");
Maybe "Memory Usage by Category" ?
> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:61
> + let chart2Element = overviewElement.appendChild(document.createElement("div"));
UI nit: on the right chart, I would use a different color than that also used for Page. This chart also lacks a subtitle documenting the data range incorporated into the chart.
> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:65
> + chart2SubtitleElement.textContent = WebInspector.UIString("High Water Mark");
This might be a big jargony for typical web developer who is just learning about memory usage. Can you add some explainer text in the tooltip?
> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:188
> + this._maxComparisonCircleChart.values = [lastRecord.totalSize, this._maxSize - lastRecord.totalSize];
Ah, I guess that answers my question. It seems to be over the entire recording, not the selected range.
> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:264
> + totalElement.appendChild(document.createElement("span")); // firstChild
You can drop the comment.
> Source/WebInspectorUI/UserInterface/Views/StackedLineChart.js:68
> + initializeSections(list)
Nit: s/list/classNames/ or similar
> Source/WebInspectorUI/UserInterface/Views/StackedLineChart.js:122
> +
Please add a comment describing the composition strategy. There are lots of ways to achieve stacked line graphs, some worse than others.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160128/e0a0dd75/attachment.html>
More information about the webkit-unassigned
mailing list