<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: High Level Memory Overview Instrument"
href="https://bugs.webkit.org/show_bug.cgi?id=153516">bug 153516</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #269943 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: High Level Memory Overview Instrument"
href="https://bugs.webkit.org/show_bug.cgi?id=153516#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: High Level Memory Overview Instrument"
href="https://bugs.webkit.org/show_bug.cgi?id=153516">bug 153516</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269943&action=diff" name="attach_269943" title="[PATCH] Proposed Fix">attachment 269943</a> <a href="attachment.cgi?id=269943&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269943&action=review">https://bugs.webkit.org/attachment.cgi?id=269943&action=review</a>
Not too much work left before this is ready to go. Please post a patch that applies cleanly so I can try it out! :) Also, please split the variable-height overview graph thing.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineOverviewGraph.js:113
> + function ysForRecord(record) {</span >
Weird name. Maybe 'scaledPointSetForRecord'. Although I would really prefer that the chart itself be passed a scale and take responsibility for applying it as necessary. I can't think of any reason why the scale would vary by category, so just two scales is enough.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:45
> +</span >
These variable names are funny =) but you should put in what the chart contains.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:46
> + let chart1Element = overviewElement.appendChild(document.createElement("div"));</span >
UI nit: it's not clear from the static screenshot where the left chart gets its data. Is it from one single instant? If so, add a subtitle.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:50
> + chart1SubtitleElement.textContent = WebInspector.UIString("Breakdown");</span >
Maybe "Memory Usage by Category" ?
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:61
> + let chart2Element = overviewElement.appendChild(document.createElement("div"));</span >
UI nit: on the right chart, I would use a different color than that also used for Page. This chart also lacks a subtitle documenting the data range incorporated into the chart.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:65
> + chart2SubtitleElement.textContent = WebInspector.UIString("High Water Mark");</span >
This might be a big jargony for typical web developer who is just learning about memory usage. Can you add some explainer text in the tooltip?
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:188
> + this._maxComparisonCircleChart.values = [lastRecord.totalSize, this._maxSize - lastRecord.totalSize];</span >
Ah, I guess that answers my question. It seems to be over the entire recording, not the selected range.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.js:264
> + totalElement.appendChild(document.createElement("span")); // firstChild</span >
You can drop the comment.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/StackedLineChart.js:68
> + initializeSections(list)</span >
Nit: s/list/classNames/ or similar
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/StackedLineChart.js:122
> +</span >
Please add a comment describing the composition strategy. There are lots of ways to achieve stacked line graphs, some worse than others.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>