[Webkit-unassigned] [Bug 153466] [GTK][EFL] JSC Sampling profiler is not enabled.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153466

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com,
                   |                            |mcatanzaro at igalia.com,
                   |                            |ossy at webkit.org,
                   |                            |wingo at igalia.com,
                   |                            |zan at falconsigh.net
            Summary|[GTK] JSC Sampling profiler |[GTK][EFL] JSC Sampling
                   |is not enabled.             |profiler is not enabled.

--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to comment #2)
> Is there someone who might be interested in trying ENABLE(SAMPLING_PROFILER)
> on Linux ports?

I have just tested this patch on top of r195735:


--- a/Source/WTF/wtf/Platform.h
+++ b/Source/WTF/wtf/Platform.h
@@ -799,7 +799,7 @@

 /* The SamplingProfiler is the probabilistic and low-overhead profiler used by
  * JSC to measure where time is spent inside a JavaScript program. */
-#if (OS(DARWIN) || OS(WINDOWS)) && ENABLE(JIT)
+#if (OS(DARWIN) || OS(LINUX) || OS(WINDOWS)) && ENABLE(JIT)
 #define ENABLE_SAMPLING_PROFILER 1
 #else
 #define ENABLE_SAMPLING_PROFILER 0


And tried to build the GTK+ port (release). I got this build error:

../../Source/JavaScriptCore/heap/MachineStackMarker.cpp:528:2: error: Need a way to get the frame pointer for another thread on this platform
#error Need a way to get the frame pointer for another thread on this platform
 ^
../../Source/JavaScriptCore/heap/MachineStackMarker.cpp:577:2: error: Need a way to get the instruction pointer for another thread on this platform
#error Need a way to get the instruction pointer for another thread on this platform
 ^
2 errors generated.

Looking at where it fails, it looks this tries to do some OS/arch-specific low-level stuff with the instruction pointers that I'm afraid I won't have the time and expertise required to fix.

If somebody else is willing to take this, feel free.

Regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160128/7b4da5d1/attachment.html>