<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] JSC Sampling profiler is not enabled."
href="https://bugs.webkit.org/show_bug.cgi?id=153466">bug 153466</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>cgarcia@igalia.com, mcatanzaro@igalia.com, ossy@webkit.org, wingo@igalia.com, zan@falconsigh.net
</td>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>[GTK] JSC Sampling profiler is not enabled.
</td>
<td>[GTK][EFL] JSC Sampling profiler is not enabled.
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] JSC Sampling profiler is not enabled."
href="https://bugs.webkit.org/show_bug.cgi?id=153466#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK][EFL] JSC Sampling profiler is not enabled."
href="https://bugs.webkit.org/show_bug.cgi?id=153466">bug 153466</a>
from <span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=153466#c2">comment #2</a>)
<span class="quote">> Is there someone who might be interested in trying ENABLE(SAMPLING_PROFILER)
> on Linux ports?</span >
I have just tested this patch on top of r195735:
--- a/Source/WTF/wtf/Platform.h
+++ b/Source/WTF/wtf/Platform.h
@@ -799,7 +799,7 @@
/* The SamplingProfiler is the probabilistic and low-overhead profiler used by
* JSC to measure where time is spent inside a JavaScript program. */
-#if (OS(DARWIN) || OS(WINDOWS)) && ENABLE(JIT)
+#if (OS(DARWIN) || OS(LINUX) || OS(WINDOWS)) && ENABLE(JIT)
#define ENABLE_SAMPLING_PROFILER 1
#else
#define ENABLE_SAMPLING_PROFILER 0
And tried to build the GTK+ port (release). I got this build error:
../../Source/JavaScriptCore/heap/MachineStackMarker.cpp:528:2: error: Need a way to get the frame pointer for another thread on this platform
#error Need a way to get the frame pointer for another thread on this platform
^
../../Source/JavaScriptCore/heap/MachineStackMarker.cpp:577:2: error: Need a way to get the instruction pointer for another thread on this platform
#error Need a way to get the instruction pointer for another thread on this platform
^
2 errors generated.
Looking at where it fails, it looks this tries to do some OS/arch-specific low-level stuff with the instruction pointers that I'm afraid I won't have the time and expertise required to fix.
If somebody else is willing to take this, feel free.
Regards.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>