[Webkit-unassigned] [Bug 150893] [ES6] Arrow function syntax. Using 'super' in arrow function that declared out of the class should lead to Syntax error

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150893

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #269925|review?                     |review+
              Flags|                            |

--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 269925
  --> https://bugs.webkit.org/attachment.cgi?id=269925
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269925&action=review

r=me with comments

> Source/JavaScriptCore/parser/Parser.h:880
> +    ScopeRef currentNotArrowfunctionFunctionScope()

I propose calling this: "closestParentNonArrowFunctionNonLexicalScope"
We really don't need it to return a function scope (and it doesn't in some cases).
It just needs to return the closest non-arrow-function function or the global scope.

> Source/JavaScriptCore/parser/Parser.h:883
> +        ASSERT(i < m_scopeStack.size());

If you're making this assertion you should also assert that m_scopeStack.size() is non zero.

> Source/JavaScriptCore/parser/Parser.h:886
> +            ASSERT(i < m_scopeStack.size());

Style: I don't think this assert adds much here

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160126/42a30f29/attachment.html>