<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Using 'super' in arrow function that declared out of the class should lead to Syntax error"
href="https://bugs.webkit.org/show_bug.cgi?id=150893">bug 150893</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #269925 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Using 'super' in arrow function that declared out of the class should lead to Syntax error"
href="https://bugs.webkit.org/show_bug.cgi?id=150893#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] Arrow function syntax. Using 'super' in arrow function that declared out of the class should lead to Syntax error"
href="https://bugs.webkit.org/show_bug.cgi?id=150893">bug 150893</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=269925&action=diff" name="attach_269925" title="Patch">attachment 269925</a> <a href="attachment.cgi?id=269925&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=269925&action=review">https://bugs.webkit.org/attachment.cgi?id=269925&action=review</a>
r=me with comments
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:880
> + ScopeRef currentNotArrowfunctionFunctionScope()</span >
I propose calling this: "closestParentNonArrowFunctionNonLexicalScope"
We really don't need it to return a function scope (and it doesn't in some cases).
It just needs to return the closest non-arrow-function function or the global scope.
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:883
> + ASSERT(i < m_scopeStack.size());</span >
If you're making this assertion you should also assert that m_scopeStack.size() is non zero.
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:886
> + ASSERT(i < m_scopeStack.size());</span >
Style: I don't think this assert adds much here</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>