[Webkit-unassigned] [Bug 153490] New: Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 26 10:20:01 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=153490

            Bug ID: 153490
           Summary: Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS
                    platforms
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: olivier.blin at softathome.com
                CC: mcatanzaro at igalia.com, zan at falconsigh.net

Build with ENABLE_DEVICE_ORIENTATION is broken on non-iOS platforms:

/WebKit/Source/WebCore/history/PageCache.cpp: In function ‘bool WebCore::canCachePage(WebCore::Page&)’:
/WebKit/Source/WebCore/history/PageCache.cpp:201:48: error: no matching function for call to ‘WebCore::DeviceMotionController::isActiveAt(WebCore::Page&)’
     if (DeviceMotionController::isActiveAt(page)) {
                                                ^
In file included from /WebKit/Source/WebCore/history/PageCache.cpp:34:0:
/WebKit/Source/WebCore/dom/DeviceMotionController.h:59:17: note: candidate: static bool WebCore::DeviceMotionController::isActiveAt(WebCore::Page*)
     static bool isActiveAt(Page*);
                 ^
/WebKit/Source/WebCore/dom/DeviceMotionController.h:59:17: note:   no known conversion for argument 1 from ‘WebCore::Page’ to ‘WebCore::Page*’
/WebKit/Source/WebCore/history/PageCache.cpp:206:53: error: no matching function for call to ‘WebCore::DeviceOrientationController::isActiveAt(WebCore::Page&)’
     if (DeviceOrientationController::isActiveAt(page)) {
                                                     ^
In file included from /WebKit/Source/WebCore/history/PageCache.cpp:35:0:
/WebKit/Source/WebCore/dom/DeviceOrientationController.h:61:17: note: candidate: static bool WebCore::DeviceOrientationController::isActiveAt(WebCore::Page*)
     static bool isActiveAt(Page*);
                 ^
/WebKit/Source/WebCore/dom/DeviceOrientationController.h:61:17: note:   no known conversion for argument 1 from ‘WebCore::Page’ to ‘WebCore::Page*’


This has been broken since r178702, which changed the Page argument from a pointer to a reference in logCanCachePageDecision().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160126/e58f1f88/attachment-0001.html>


More information about the webkit-unassigned mailing list