<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms"
href="https://bugs.webkit.org/show_bug.cgi?id=153490">153490</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>Other
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebCore Misc.
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>olivier.blin@softathome.com
</td>
</tr>
<tr>
<th>CC</th>
<td>mcatanzaro@igalia.com, zan@falconsigh.net
</td>
</tr></table>
<p>
<div>
<pre>Build with ENABLE_DEVICE_ORIENTATION is broken on non-iOS platforms:
/WebKit/Source/WebCore/history/PageCache.cpp: In function ‘bool WebCore::canCachePage(WebCore::Page&)’:
/WebKit/Source/WebCore/history/PageCache.cpp:201:48: error: no matching function for call to ‘WebCore::DeviceMotionController::isActiveAt(WebCore::Page&)’
if (DeviceMotionController::isActiveAt(page)) {
^
In file included from /WebKit/Source/WebCore/history/PageCache.cpp:34:0:
/WebKit/Source/WebCore/dom/DeviceMotionController.h:59:17: note: candidate: static bool WebCore::DeviceMotionController::isActiveAt(WebCore::Page*)
static bool isActiveAt(Page*);
^
/WebKit/Source/WebCore/dom/DeviceMotionController.h:59:17: note: no known conversion for argument 1 from ‘WebCore::Page’ to ‘WebCore::Page*’
/WebKit/Source/WebCore/history/PageCache.cpp:206:53: error: no matching function for call to ‘WebCore::DeviceOrientationController::isActiveAt(WebCore::Page&)’
if (DeviceOrientationController::isActiveAt(page)) {
^
In file included from /WebKit/Source/WebCore/history/PageCache.cpp:35:0:
/WebKit/Source/WebCore/dom/DeviceOrientationController.h:61:17: note: candidate: static bool WebCore::DeviceOrientationController::isActiveAt(WebCore::Page*)
static bool isActiveAt(Page*);
^
/WebKit/Source/WebCore/dom/DeviceOrientationController.h:61:17: note: no known conversion for argument 1 from ‘WebCore::Page’ to ‘WebCore::Page*’
This has been broken since r178702, which changed the Page argument from a pointer to a reference in logCanCachePageDecision().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>